The old swatches panel and color palette were pretty good at losing track of the document and not dynamically updating themselves any more. The parser was also rewritten in about half as many lines of code using regexes, which is great because hand-written parsers are a favourite place for security vulnerabilities to hang out. If a palette file couldn't be loaded due to being malformed, you now get an error on the console as to why.
They should also stay in sync better previously they could take some time to appear.Īctual informative error messages if a palette file is malformed Don't worry about the performance cost the implementation is very efficient (only two hash lookups per selection change). After recently being restored in !4276 (merged), they now have a nicer, unobtrusive look, and work for ordinary colours too. After changing things so that only changed gradients are repainted, and batching all updates to the next frame, the delay should hopefully no longer be necessary: This was to paper over a performance problem which resulted from the fact all gradients were updated when any one of them were changed. Previously there was a deliberate 90 ms delay for all updates to the swatches. It should also lead to slightly improved loading times in theory, but I don't think they're really noticeable. Fixing it eliminates the "sticking" while holding Ctrl+W, while also all but killing the memory leak: For example, it did so on every Ctrl+W of an empty document. The old code rebuilt the color palette from scratch all the time in response to unimportant changes.
(*Not to be confused with color-palette.cpp, the internal child widget, which was recently rewritten by and which I haven't touched.) User-facing changes Several whole files were rewritten from scratch, all while preserving the same functionality.
This MR is a complete rewrite of the extremely crufty Swatches Dialog / Color Palette*, boosting performance, fixing glitchiness, memory leaks, and adding/augmenting features along the way.
0 kommentar(er)
